<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Verdana;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Verdana","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Verdana","sans-serif";color:#1F497D">I have finally cracked # 2 in rev 518. Despite how long it took to track down, it turned out to be a stupid, stupid error. Sorry!!<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Verdana","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Verdana","sans-serif";color:#1F497D">Andrew.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Verdana","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> cwb-bounces@sslmit.unibo.it [mailto:cwb-bounces@sslmit.unibo.it]
<b>On Behalf Of </b>Markus Killer<br>
<b>Sent:</b> 22 January 2014 14:01<br>
<b>To:</b> cwb@sslmit.unibo.it<br>
<b>Subject:</b> Re: [CWB] CQPweb: upgrade-database.php v3.0.16 > v3.1.0<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<div>
<div>
<div>
<div>
<p class="MsoNormal"><span style="font-family:"Courier New"">Hi Andrew,</span><span style="font-family:"Calibri","sans-serif""><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Courier New"">(1) - MY MISTAKE</span><span style="font-family:"Calibri","sans-serif""><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Courier New"">I completely understand your reason for disabling the deletion of the password column and the alert note is clearly visible.</span><span style="font-family:"Calibri","sans-serif""><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Courier New"">I tried to replicate the 'password into email column' behaviour on a clean virtual machine and it didn't happen again. This must have been a misconfiguration in my original 3.0.16 database (i.e. password
stored in password AND email column - probably an auto-form-fill slip in phpmyadmin). I'll try to verify this later with an archived sql-dump, as I have reset the system to an earlier state in the meantime. </span><span style="font-family:"Calibri","sans-serif""><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Courier New"">My apologies, I really should have double-checked before filing this one.</span><span style="font-family:"Calibri","sans-serif""><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Courier New"">(2) - BUG STILL PRESENT</span><span style="font-family:"Calibri","sans-serif""><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Courier New"">@rev 515: </span><span style="font-family:"Calibri","sans-serif""><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Courier New"">upgrade-database.php terminates without any warnings or errors, but password is still not hashed -> the value is NULL (see column 8 of upgraded database below)</span><span style="font-family:"Calibri","sans-serif""><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif"">mysql> select * from cqpwdebug.user_info;<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif"">+----+----------+----------+----------------+----------------------+-------------+---------+----------+-------------+------------+-------------+----------------------+---------------------+---------------------+---------------+-------------------+------------+-------------------+--------------+---------------------------+----------------+-------------------+----------------+-----------+---------+------------+----------+<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif"">| id | username | password | realname | email | affiliation | country | passhash | acct_status | verify_key | expiry_time | password_expiry_time | last_seen_time
| acct_create_time | conc_kwicview | conc_corpus_order | cqp_syntax | context_with_tags | use_tooltips | thin_default_reproducible | coll_statistic | coll_freqtogether | coll_freqalone | coll_from | coll_to | max_dbsize | linefeed |<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif"">+----+----------+----------+----------------+----------------------+-------------+---------+----------+-------------+------------+-------------+----------------------+---------------------+---------------------+---------------+-------------------+------------+-------------------+--------------+---------------------------+----------------+-------------------+----------------+-----------+---------+------------+----------+<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif"">| 1 | mkiller | debugpass | unknown person |
<a href="mailto:markus.killer@uzh.ch">markus.killer@uzh.ch</a> | NULL | 00 | NULL | 1 | NULL | 0 | 0 | 0000-00-00 00:00:00 | 0000-00-00 00:00:00 | 1 | 1 | 0 |
0 | 1 | 1 | 6 | 5 | 5 | -3 | 3 | 1000000 | au |<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif"">+----+----------+----------+----------------+----------------------+-------------+---------+----------+-------------+------------+-------------+----------------------+---------------------+---------------------+---------------+-------------------+------------+-------------------+--------------+---------------------------+----------------+-------------------+----------------+-----------+---------+------------+----------+<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif"">1 row in set (0.00 sec)<o:p></o:p></span></p>
</div>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif"">When trying to login to the upgraded system, I get this message:<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
</div>
<div>
<table class="MsoNormalTable" border="0" cellpadding="0" width="100%" style="width:100.0%">
<tbody>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt">
<p class="MsoNormal" align="center" style="text-align:center"><b>Your login was not successful.<o:p></o:p></b></p>
</td>
</tr>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt">
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">The credentials you entered are not valid.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt">
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Please go back to the log on page and try again.<o:p></o:p></p>
</td>
</tr>
</tbody>
</table>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif"">Best wishes,<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif"">Markus<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
</div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif"">> From: <a href="mailto:a.hardie@lancaster.ac.uk">
a.hardie@lancaster.ac.uk</a><br>
> To: <a href="mailto:cwb@sslmit.unibo.it">cwb@sslmit.unibo.it</a><br>
> Date: Wed, 22 Jan 2014 12:04:36 +0000<br>
> Subject: Re: [CWB] CQPweb: upgrade-database.php v3.0.16 > v3.1.0<br>
> <br>
> Hi Markus,<br>
> <br>
> I have been puzzling over this at great length and have got nowhere. <br>
> <br>
> (1) The old password column exists because I disabled its deletion to make rollback easier if needed. (There is an alert note in the printed output telling people to drop the password column manually after the fact).<br>
> <br>
> But the old password going into the email column is something I just can't figure out. It's not happened on the system I upgraded (albeit that wasn't with 512 but an earlier version) and I can't find anything in the code of upgrade-database that ought to
alter the contents of the email column in that way.<br>
> <br>
> (2) Likewise this puzzles me, there WAS a bug that did this, but I thought I had fixed it in commit 502.<br>
> <br>
> So, if you can add any further details related to this bug that might help me track it down, that would be very much appreciated....<br>
> <br>
> best<br>
> <br>
> Andrew.<br>
> <br>
> -----Original Message-----<br>
> From: <a href="mailto:cwb-bounces@sslmit.unibo.it">cwb-bounces@sslmit.unibo.it</a> [<a href="mailto:cwb-bounces@sslmit.unibo.it">mailto:cwb-bounces@sslmit.unibo.it</a>] On Behalf Of Markus Killer<br>
> Sent: 21 January 2014 13:10<br>
> To: Open source development of the Corpus WorkBench<br>
> Subject: Re: [CWB] CQPweb: upgrade-database.php v3.0.16 > v3.1.0<br>
> <br>
> upgrade-database.php rev512 runs smoothly now, but there seem to be two more issues:<br>
> <br>
> (1) - the old password is mapped into table:user_info column:password and accidentally, I think, into column:email as well<br>
> <br>
> (2) - the password is not hashed (passhash: NULL) and, consequently, authentication fails.<br>
> <br>
> --> not possible to login as superuser after running upgrade-database.php (unless you manually add passhash)<br>
> <br>
> <br>
> ----------------------------------------<br>
> > From: <a href="mailto:a.hardie@lancaster.ac.uk">a.hardie@lancaster.ac.uk</a><br>
> > To: <a href="mailto:m.killer@outlook.com">m.killer@outlook.com</a>; <a href="mailto:cwb@sslmit.unibo.it">
cwb@sslmit.unibo.it</a><br>
> > Date: Tue, 21 Jan 2014 12:50:34 +0000<br>
> > Subject: Re: [CWB] CQPweb: upgrade-database.php v3.0.16> v3.1.0<br>
> ><br>
> > Think I've squished that one in 512.<br>
> ><br>
> > Andrew.<br>
> ><br>
> > -----Original Message-----<br>
> > From: <a href="mailto:cwb-bounces@sslmit.unibo.it">cwb-bounces@sslmit.unibo.it</a> [<a href="mailto:cwb-bounces@sslmit.unibo.it">mailto:cwb-bounces@sslmit.unibo.it</a>] On Behalf Of Markus Killer<br>
> > Sent: 21 January 2014 10:48<br>
> > To: Open source development of the Corpus WorkBench<br>
> > Subject: [CWB] CQPweb: upgrade-database.php v3.0.16> v3.1.0<br>
> ><br>
> > upgrade-database on exact copy of working v3.0.16 db:<br>
> ><br>
> > Revision 510.<br>
> > mki@ubuntu:/var/www/cqp-web-beta/bin$ sudo php upgrade-database.php Database version is now at < 3.1.0. Database will now be upgraded to 3.1.0...<br>
> > A mySQL query did not run successfully!<br>
> ><br>
> > Original query:<br>
> ><br>
> > alter table system_messages alter column fromto set default NULL<br>
> ><br>
> > Error # 1067: Invalid default value for 'fromto'<br>
> ><br>
> > **************<br>
> > DESCRIBE - BEFORE SCRIPT:<br>
> ><br>
> > mysql> describe cqpwbeta.system_messages;<br>
> > +------------+--------------+------+-----+-------------------+-----------------------------+<br>
> > | Field | Type | Null | Key | Default | Extra |<br>
> > +------------+--------------+------+-----+-------------------+-----------------------------+<br>
> > | message_id | varchar(150) | NO | PRI | NULL | | timestamp | timestamp<br>
> > | | NO | | CURRENT_TIMESTAMP | on update CURRENT_TIMESTAMP | header |<br>
> > | varchar(150) | NO | | | | content | text | NO | | NULL | | fromto |<br>
> > | varchar(150) | NO | | | |<br>
> > +------------+--------------+------+-----+-------------------+-----------------------------+<br>
> > 5 rows in set (0.00 sec)<br>
> ><br>
> ><br>
> ><br>
> > ----------------------------------------<br>
> >> From: <a href="mailto:a.hardie@lancaster.ac.uk">a.hardie@lancaster.ac.uk</a><br>
> >> To: <a href="mailto:cwb@sslmit.unibo.it">cwb@sslmit.unibo.it</a>; <a href="mailto:m.killer@outlook.com">
m.killer@outlook.com</a><br>
> >> Date: Tue, 21 Jan 2014 10:17:22 +0000<br>
> >> Subject: Re: [CWB] CQPweb: v 3.1.0 now usable, I think<br>
> >><br>
> >> (For the benfit of the peanut gallery: Markus sent me the "describe.... off list, and it had this line:<br>
> >><br>
> >> | dbname | varchar(200) | NO | PRI | NULL | |<br>
> >><br>
> >> )<br>
> >><br>
> >> So again, it's a case of rollback being needed so the script can run again.<br>
> >><br>
> >> The next bug is a phasing issue, it looks as if some of the DB changes which I put in there for 3.0.16 are not in the right place, they should have been assigned to 3.0.15. Commit 510 has all of those that I can find fixed.<br>
> >><br>
> >> best<br>
> >><br>
> >> Andrew.<br>
> > _______________________________________________<br>
> > CWB mailing list<br>
> > <a href="mailto:CWB@sslmit.unibo.it">CWB@sslmit.unibo.it</a><br>
> > <a href="http://devel.sslmit.unibo.it/mailman/listinfo/cwb">http://devel.sslmit.unibo.it/mailman/listinfo/cwb</a><br>
> > _______________________________________________<br>
> > CWB mailing list<br>
> > <a href="mailto:CWB@sslmit.unibo.it">CWB@sslmit.unibo.it</a><br>
> > <a href="http://devel.sslmit.unibo.it/mailman/listinfo/cwb">http://devel.sslmit.unibo.it/mailman/listinfo/cwb</a>
<br>
> _______________________________________________<br>
> CWB mailing list<br>
> <a href="mailto:CWB@sslmit.unibo.it">CWB@sslmit.unibo.it</a><br>
> <a href="http://devel.sslmit.unibo.it/mailman/listinfo/cwb">http://devel.sslmit.unibo.it/mailman/listinfo/cwb</a><br>
> _______________________________________________<br>
> CWB mailing list<br>
> <a href="mailto:CWB@sslmit.unibo.it">CWB@sslmit.unibo.it</a><br>
> <a href="http://devel.sslmit.unibo.it/mailman/listinfo/cwb">http://devel.sslmit.unibo.it/mailman/listinfo/cwb</a><o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>